Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: supplements ckb-gen-types with two type conversions that used to exist in ckb-standalone-types #4293

Merged

Conversation

EthanYuan
Copy link
Collaborator

@EthanYuan EthanYuan commented Jan 6, 2024

What problem does this PR solve?

Problem Summary:

ckb-gen-types complements the two type conversions that used to exist in ckb-standalone-types.

User feedback from:
nervosnetwork/ckb-std#71 (comment)

What is changed and how it works?

What's Changed:

impl<'r> Unpack<[u8; 32]> for Byte32;
impl<'r> Unpack<[u8; 10]> for ProposalShortId;

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Release note

Title Only: Include only the PR title in the release note.

@EthanYuan EthanYuan requested a review from a team as a code owner January 6, 2024 13:14
@EthanYuan EthanYuan requested review from zhangsoledad and quake and removed request for a team January 6, 2024 13:14
@quake quake added this pull request to the merge queue Jan 8, 2024
Merged via the queue into nervosnetwork:develop with commit 7570a27 Jan 8, 2024
33 checks passed
@EthanYuan EthanYuan deleted the add-missing-type-conversions branch January 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants